Use HTTPS instead of protocol-relative CDN URLs#91
Use HTTPS instead of protocol-relative CDN URLs#91hubgit wants to merge 2 commits intojquery:masterfrom
Conversation
|
Hey @hubgit! Thanks for your pull request. It looks like you signed the CLA with a private GitHub email address, which we specifically don't allow: jquery/jquery-license@fdb6b24. Could you please sign with your real email and update the git config? Thanks! |
3a62dac to
3e345bd
Compare
0a47015 to
537e3f5
Compare
pages/download.md
Outdated
There was a problem hiding this comment.
just reference the file directly from
http://code.jquery.comin the script tag:
Should we update this one as well?
|
Updated to convert as many URLs as possible to HTTPS (if that's too much I can just make the single change, but these might as well be updated at some point). |
|
@arthurvr This should be ok now? |
|
So, are we doing it? I think it's a good change. @kborchers, AFAIK you had some opinions here? :) |
|
As long as the links work I am fine with this change. The specific incident that got me involved was with a protocol-relative link to sizzlejs.com from https which caused the link to be broken as there is no cert for sizzlejs.com |
|
Updated to fix merge conflicts. |
|
Fixed in e37ea3f . |
Quoting @paulirish:
http://www.paulirish.com/2010/the-protocol-relative-url/
fixes #86